Skip to content

Use hash of repo path, ref and entrypath as cache key #12151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 5, 2020
Merged

Use hash of repo path, ref and entrypath as cache key #12151

merged 2 commits into from
Jul 5, 2020

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Jul 5, 2020 •
edited
Loading

Fixes #12149

If repository contains long file names it could error out currently that cache key is too long

@lafriks lafriks added this to the 1.13.0 milestone Jul 5, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 5, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 5, 2020
@lafriks
Copy link
Member Author

lafriks commented Jul 5, 2020

🚀

@lafriks lafriks merged commit 4384320 into go-gitea:master Jul 5, 2020
@lafriks lafriks deleted the fix/last_cache_cachekey_length branch July 5, 2020 22:40
lafriks added a commit to lafriks-fork/gitea that referenced this pull request Jul 6, 2020
@lafriks
Use hash of repo path, ref and entrypath as cache key (go-gitea#12151)
b04afd7
@lafriks lafriks mentioned this pull request Jul 6, 2020
Merged
@lafriks lafriks added the backport/done All backports for this PR have been created label Jul 6, 2020
lunny pushed a commit that referenced this pull request Jul 6, 2020
@lafriks
Use hash of repo path, ref and entrypath as cache key (#12151) (#12161)
3daedb3
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@lafriks
Use hash of repo path, ref and entrypath as cache key (go-gitea#12151)
b68d3cf
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

Project mirror isn't workin
4 participants
@lafriks @techknowlogick @zeripath @GiteaBot